rust-lang / rust-lang/rust-clippy
new lint: reflexive String queries: s.find(&s)
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
This was inspired by a cppcheck lint.
operations like s.find(&s); on strings will always yield the same results so they are probably not intentional.
fn main() {
let s = String::from("hello world");
let a = s.find(&s); // always 0
let b = s.ends_with(&s); // always true
let c = s.contains(&s); // always true
let d = s.starts_with(&s); // always true
}
currently, none of these trigger a related warning.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no implementation file or test. Start by locating Clippy’s existing String-method lints and their UI tests, then verify the four self-query examples produce diagnostics without false positives; done means the new lint is registered and its expected warnings pass.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100