rust-lang / rust-lang/rust-clippy
new lint: suggest pulling identical methods out of conditional BBs
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
#[cfg_attr(feature = "cargo-clippy", warn(pedantic))]
fn main() {
let x = 4;
let y = if x > 4 {
String::from("hello world").repeat(2).to_uppercase().replace("world", "universe")
} else {
String::from("hello world").to_uppercase().replace("world", "universe")
};
println!("{}", y);
}
This could be deduplicated slightly to
fn main() {
let x = 4;
let y = if x > 4 {
String::from("hello world").repeat(2)
} else {
String::from("hello world")
}.to_uppercase()
.replace("world", "universe");
println!("{}", y);
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue provides Rust examples but names no source file, test, or entry point. Start by using the examples to define the requested lint behavior and suggested rewrite, then locate the existing lint and test patterns before verifying coverage for equivalent conditional branches.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100