FN: useless format: formatting PathBuf.display()

Open
#3,021 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Stale
Tech stack
rust
Domain
tooling

Research direction

Start by locating the lint implementation that analyzes format! calls involving PathBuf.display(), then inspect the existing lint test conventions. The work is done when the example is diagnosed as unnecessary formatting and the relevant lint tests verify the suggested direct use of display().

Written by the indexing model from the issue text.

Description

C-bug I-false-negative 
use std::path::PathBuf;

fn main() {
    let x = PathBuf::from("/bar/foo/qux");
    let y = format!("{}", x.display()); // can just be   let y = x.display();
    println!("{}", y);
}
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rust-lang/rust-clippy

All issues in rust-lang/rust-clippy

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.