rust-lang / rust-lang/rust-clippy

new lint: unneccessary iterator conversion: vec -> iter -> reverse -> collect -> vec

Open
#2,970 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

if we have a Vec and vec.into_iter().rev().collect::<Vec<_>>(), we should probably just vec.reverse().

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Locate the existing lint implementations and tests for iterator-conversion patterns, then check how this Vec expression is represented and diagnosed. Done means the unnecessary conversion is reported with an appropriate suggestion to reverse the Vec directly, with coverage for the stated pattern.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.