rust-lang / rust-lang/rust-clippy

Potentially redundant/upliftable lints

Open
#2,846 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

C-an-interesting-project S-triage
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

A few lints I noticed which may be redundant to newer lints in rustc upstream:

  • absurd_extreme_comparisons should be uplifted to the existing unused_comparisons
  • bad_bit_mask should probably be uplifted to the existing unused_comparisons lint, or an unused_bitmask lint
  • bool_comparison should probably be uplifted to unused_comparisons
  • cmp_nan should probably be again uplifted to unused_comparisons
  • eq_op should probably be again uplifted to unused_comparisons
  • unused_collect should be replaced by the existing must_use on collect
  • useless_attribute should be replaced by unused_attribute
  • out_of_bounds_indexing should be a const eval error
  • iterator_step_by_zero should be removed; this now panics
  • enum_clike_unportable_variant should be part of a compiler portability lint

(will make larger list when I get around to it)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ten lints listed in issue #2846 and compare each with its current rustc upstream or Clippy status. Done means reaching a decision for every listed lint—uplift, replacement, removal, or compiler portability handling—and documenting or implementing those decisions.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.