rust-lang / rust-lang/rust-clippy
Potentially redundant/upliftable lints
Open
Nobody has claimed this yet.
C-an-interesting-project
S-triage
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
A few lints I noticed which may be redundant to newer lints in rustc upstream:
absurd_extreme_comparisonsshould be uplifted to the existingunused_comparisonsbad_bit_maskshould probably be uplifted to the existingunused_comparisonslint, or anunused_bitmasklintbool_comparisonshould probably be uplifted tounused_comparisonscmp_nanshould probably be again uplifted tounused_comparisonseq_opshould probably be again uplifted tounused_comparisonsunused_collectshould be replaced by the existingmust_useoncollectuseless_attributeshould be replaced byunused_attributeout_of_bounds_indexingshould be a const eval erroriterator_step_by_zeroshould be removed; this now panicsenum_clike_unportable_variantshould be part of a compiler portability lint
(will make larger list when I get around to it)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the ten lints listed in issue #2846 and compare each with its current rustc upstream or Clippy status. Done means reaching a decision for every listed lint—uplift, replacement, removal, or compiler portability handling—and documenting or implementing those decisions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100