rust-lang / rust-lang/rust-clippy

change versioning scheme of clippy_lints

Open
#2,761 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

S-needs-discussion
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

As mentioned in https://github.com/rust-lang/rust/pull/50767, updating the clippy submodule in the rustc repo can break rls and thus break nightlies.

Yesssss!, we can now ensure that all nightlies have a working clippy if we want to

No we are of course not doing this :P

Anyway. My suggestion is to change the versioning scheme of the clippy_lints crate. Instead of syncing with the clippy crate, we start producing 0.x.y versions, where x is updated when we change the API of clippy_lints (so when rustc forces us to change the API) and y is updated whenever we do a rustup.

This means there'll be a lot fewer version bumps to the clippy crate, as the clippy_lints crate in the background would automatically update via patch versions.

Is this suggestion abusing semver? Other ideas?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the linked rust-lang/rust pull request and tracing how the clippy and clippy_lints crate versions are currently synchronized. Check the impact on rustc, rls, and nightly rustup updates. Done means there is an agreed versioning approach that avoids breaking RLS or nightlies and is documented well enough to implement.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.