rust-lang / rust-lang/rust-clippy
new lint: suggest using iterator instead of casting iterator to vector end using vector, in simple cases
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
code snippet:
fn main() {
let x = String::from("this-is-a-string");
let y: Vec<&str> = x.split("-").collect(); // vec
for i in y {
println!("{}", i);
}
}
if we know that we use x only for iterating over the items once, we can ommit the transformation to a vector completely which is more idiomatic and can be slightly faster I think:
fn main() {
let x = String::from("this-is-a-string");
let mut y = x.split("-"); // iterator
for i in y {
println!("{}", i);
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, test, or entry point is named in the issue. Start with the Rust examples and inspect existing Clippy lint patterns; done means the simple collect-to-vector case is recognized and an iterator-based suggestion is produced without covering cases outside the stated scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100