rust-lang / rust-lang/rust-clippy
Lint manual bounds checks that have dedicated methods
Open
Nobody has claimed this yet.
A-lint
L-unnecessary
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
For example, things like if idx < s.len() { Some(s[idx]) } else { None } could be replaced with s.get(idx).cloned().
There are also other bounds checks like if idx < s.len() { do_something(s[idx]); } that could be replaced with s.get(idx).map(do_something).
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by locating the existing Clippy lint infrastructure for manual bounds checks, then compare the two examples in the issue against supported Rust patterns. Done means detecting these checks and offering appropriate replacements using get().cloned() or get().map(do_something), with tests covering both forms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100