rust-lang / rust-lang/rust-clippy
Detect useless PhantomData
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Twice in a few days, after refactoring code, I've ended up with unnecessary PhantomData. And while the compiler complains when PhantomData is necessary (although not directly speaking of PhantomData), there is currently nothing that detects when they are (still) used but the code doesn't require them anymore.
OTOH, there are a few cases where they are used but where the compiler would not require them, in libstd or libcore.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by tracing how Clippy currently handles PhantomData and compare cases where the compiler requires it with the libstd and libcore cases where it remains intentional; done means detecting unnecessary uses without flagging those exceptions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100