rust-lang / rust-lang/rust-clippy
Suggest implementing rand::Rand trait
Open
Nobody has claimed this yet.
A-lint
E-medium
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
This could look for types that have a constructor taking only a type implementing rand::Rng (from the rand crate) as an argument:
extern crate rand;
use rand::Rng;
struct Foo(u64);
impl Foo {
fn new_random<R: Rng>(rng: &mut R) -> Self {
Foo(rng.gen::<u64>())
}
}
should become:
impl Rand for Foo {
fn rand<R: Rng>(rng: &mut R) -> Self {
Foo(rng.gen::<u64>())
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files, tests, or entry points are named. Start by locating Clippy's lint registration and existing lints that inspect constructors or trait bounds, then check how lint tests are organized. Done means detecting the described rand::Rng constructor pattern and validating the suggested rand::Rand implementation through tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100