rust-lang / rust-lang/rust-clippy

Suggest into_owned instead of to_string for Cow<str>

Open
#2,387 7 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint E-medium T-middle
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Note serde-rs/json#405.

We could also lint to_vec on Cow<[T]> and probably others.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading serde-rs/json#405 and locating Clippy's existing handling for Cow conversions. Confirm the intended lint for to_string, then decide whether to_vec and other Cow<[T]> conversions belong in the same scope; done means the agreed cases are linted with appropriate coverage.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.