rust-lang / rust-lang/rust-clippy

Lint to suggest match instead of [...].contains

Open
#2,345 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

This is a common pattern from python that can be done more efficiently in Rust. Essentially, converting something from the form x in (a, b, c) to the Rust equivalent [a, b, c].contains(x) is not as ideal as match { a | b | c => ..., _ => () }.

This might not be as easily auto-fixable, as the code could probably be restructured better, but this is a good idea for a lint at least.

Anything that involves creating an array or slice of constants and immediately calling contains is a candidate.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the proposed pattern in the issue body: an array or slice of constants immediately passed to contains. Review existing Clippy lint entry points and tests for similar collection or match suggestions, then define the supported cases and confirm completion by adding coverage for the recognized pattern and its diagnostic behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.