rust-lang / rust-lang/rust-clippy
Lint to suggest match instead of [...].contains
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
This is a common pattern from python that can be done more efficiently in Rust. Essentially, converting something from the form x in (a, b, c) to the Rust equivalent [a, b, c].contains(x) is not as ideal as match { a | b | c => ..., _ => () }.
This might not be as easily auto-fixable, as the code could probably be restructured better, but this is a good idea for a lint at least.
Anything that involves creating an array or slice of constants and immediately calling contains is a candidate.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start from the proposed pattern in the issue body: an array or slice of constants immediately passed to contains. Review existing Clippy lint entry points and tests for similar collection or match suggestions, then define the supported cases and confirm completion by adding coverage for the recognized pattern and its diagnostic behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100