rust-lang / rust-lang/rust-clippy
Lint implementing Deref with a target outside the crate
Open
Nobody has claimed this yet.
A-lint
E-medium
S-needs-discussion
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
This is often a misuse of the Deref trait, and often enough to the point where it probably should be linted by default. If you really want to implement Deref, just add an allow.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points; start by searching the repository for existing Deref-related lints and their tests. Confirm the intended default lint behavior for implementations whose target is outside the crate, including the documented allow escape, then add coverage for the accepted and warned cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100