rust-lang / rust-lang/rust-clippy

Lint functions with exactly the same body

Open
#2,263 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint E-medium T-AST
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

This could probably be an AST check; it doesn't have to be complicated. Just a really simple thing to check if something is an obvious copy-paste error. If two functions have the same body, the user should just call one from the other, or change the bodies so they're not the same.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by locating Clippy's AST-based lint entry points and existing lint test conventions, then determine how function bodies would be compared. Done means a lint reports obvious functions with identical bodies and includes coverage in the relevant test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.