rust-lang / rust-lang/rust-clippy
False positive in derive_hash_xor_eq with multiple `Eq` implementations
Open
Nobody has claimed this yet.
C-bug
I-false-positive
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
In optional, I have both the standard derived Eq and Hash, plus one extra Eq impls on references for improved ergonomics. However, this additional Eq' impl triggers the derive_hash_xor_eq` lint. So perhaps the lint should look for existing derived implementations to avoid this false positive.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the derive_hash_xor_eq lint and its existing tests, then reproduce the multiple-Eq implementation pattern described in the issue. Add coverage for the derived Eq and Hash implementations plus the extra reference Eq impl; done means this case is no longer reported as a false positive.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100