rust-lang / rust-lang/rust-clippy
Add automatically applicable suggestion to unused_label
Open
Nobody has claimed this yet.
A-lint
L-suggestion
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Found by running rustfix on https://github.com/space-wizards/bsdiff-rs.
I suggest suggesting (heh) to replace 'loop7: with an empty string. (Might need special casing in diagnostics rendering?)
warning: unused label `'loop7`
--> src/diff.rs:468:13
|
468 | / 'loop7: loop {
469 | | if !(scsc < scan + len) {
470 | | break;
471 | | }
... |
477 | | scsc += 1isize;
478 | | }
| |_____________^
|
= note: #[warn(unused_label)] on by default
= help: for further information visit https://github.com/Manishearth/rust-clippy/wiki#unused_label
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Find the implementation of the unused_label lint and inspect how its diagnostics and suggestions are rendered. Reproduce the warning from the example with rustfix, then add the applicable replacement suggestion and verify that the diagnostic renders it correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100