Lint against Sync return values from un-Sync types

Open

#1,842 opened on Jun 22, 2017 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint

Dominant language: Rust
Stars: 13.5k
Forks: 2.2k
Avg merge: 2d 10h
Merged PRs (30d): 32

Description

Following @Gankro 's blog post, the first bug (found by @RalfJung) is (IIRC) about methods on non-Synctypes that return a mutable reference to (parts of)Sync` members of the type.

We could try to lint against such methods to ensure it won't happen again.

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.

Research direction

Start by reading the issue and the linked blog posts about unsafe auto traits and MutexGuard. Determine how Clippy could identify methods on non-Sync types that return mutable references to Sync members; done means a defined lint with coverage for the described pattern and appropriate tests.

Written by the indexing model from the issue text.

Assessment

Tech stack: rust
Domain: security, tooling
Issue type: Feature
Difficulty: 5/5
Estimated time: Over a week
Activity status: Stale
Clarity: Mostly clear
Newbie friendliness: 35/100

A short digest of beginner-friendly GitHub issues.