rust-lang / rust-lang/rust-clippy
Extensions to should_assert_eq
Open
Nobody has claimed this yet.
C-enhancement
good first issue
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
I found this in the standard library:
assert!(o == owned && b == borrowed)
This should be a case for should_assert_eq. Additionally, it might be nice to have a lint that suggests splitting asserts with && to multiple assert statements, for better debugging.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the should_assert_eq lint implementation and its existing tests, then inspect how the standard-library assertion o == owned && b == borrowed is handled. Define completion as coverage for this case and a clear decision on whether splitting && assertions belongs in the same or a separate lint, with tests for the chosen behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 55/100