rust-lang / rust-lang/rust-clippy
comparison with x.as_str() where x suffices
Open
Nobody has claimed this yet.
A-lint
E-medium
S-needs-discussion
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
We recently had some instances where we compared name.as_str() == s albeit there was an impl PartialEq<&str>.
I say this should either be allowed by default or use a blacklist of types where we know that the aforementioned impl has the same semantics as the conversion + str-equality.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Read the existing discussion first, then determine whether comparisons using x.as_str() should be allowed by default or handled through a type blacklist, and define tests that establish the intended semantics before considering the issue complete.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools, tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100