rust-lang / rust-lang/rust-clippy

Lints to suggest deriving more traits

Open
#1,781 11 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint E-medium T-middle
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

A few suggestions:

  1. If a type derives Eq, it should also derive Hash.
  2. If a type is trivial (e.g. a unit struct or an enum of only unit variants) we should suggest to implement Copy, Eq, Default, Hash, and their dependencies.
  3. If a type derives PartialEq but could also derive Eq, suggest deriving Eq.
  4. Similar to 3 but with Ord.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue proposes four related groups of derive-trait lints but names no implementation files or tests. Start by locating the existing derive-related lint entry points and test conventions, then narrow the scope and define dependency and suggestion behavior for each case; done means the agreed suggestions are implemented with coverage for the listed type forms.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.