rust-lang / rust-lang/rust-clippy
Regression for `float_cmp` in `assert_eq!(x, 1.0)`
Open
Nobody has claimed this yet.
C-bug
I-false-negative
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Description
This code snippet no longer raises any diagnostic: assert_eq!(x, 1.0)
It should raise float_cmp or float_cmp_const.
The regression was introduced in #17024
Version
rustc 1.99.0-nightly (84b36a78a 2026-08-06)
binary: rustc
commit-hash: 84b36a78a28a63f134171c670be1932ffa2485f8
commit-date: 2026-08-06
host: x86_64-unknown-linux-gnu
release: 1.99.0-nightly
LLVM version: 23.1.0
Additional Labels
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the assert_eq!(x, 1.0) snippet with the reported Rust nightly and inspect the float_cmp and float_cmp_const lint entry points. Compare the current behavior with the change introduced in issue #17024. Done means the snippet emits the appropriate diagnostic again.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 68/100