rust-lang / rust-lang/rust-clippy

Recommend `match` instead of `.map().map_err()` chaining

Open
#17,469 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Warn against x.map(...).map_err(...) chaining on a Result and recommend a match instead.

Advantage
  • More readable.
  • Clearer to the reader and to the compiler that the match is exhaustive.
Drawbacks

None that I can think of, other than style and personal taste.

Example
res.map(f).map_err(g)

Could be written as:

match res {
    Ok(x) => Ok(f(x)),
    Err(y) => Ok(g(y)),
}
Comparison with existing lints

No response

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing existing Clippy lint implementations and tests for Result combinators, then compare their handling of chained map and map_err calls with the example in this issue. Define the lint's intended scope and diagnostics, and consider whether the proposed match is consistently clearer before adding coverage that verifies the warning and replacement guidance.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.