rust-lang / rust-lang/rust-clippy

Lint on converting to/from serde_*::Value instead of directly implementing Serialize/Deserialize

Open
#1,718 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Basically, we want to avoid code that converts String to Value to a type defined in the current crate, because the types should implement Deserialize directly instead. Similarly for the other direction and Serialize.

Because these types can also act as serializers/deserializers you should always just implement Serialize or Deserialize because it's cleaner.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating Clippy's existing lint entry points and test structure, then inspect how conversions to and from serde_*::Value are represented. Done means a lint identifies these conversions and tests demonstrate the intended direct Serialize or Deserialize implementations.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.