rust-lang / rust-lang/rust-clippy

Using `Path::display` to construct a new `Path`

Open
#17,157 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Detect when FS operations are being done using a fresly-constructed String from Paths. Instead, devs should be using Path::join to avoid an unnecessarily lossy transformation.

Advantage

Code is more robust to paths that are not representable by UTF-8 strings.

Drawbacks

The detection logic might be too difficult to accomplish for the general case.

The correct code might be difficult to automatically suggest.

Example
    let p = "foo";
    let bar = "bar";
    let _ = fs::create_file(format!("{}/bar", p.display()));
    let _ = fs::create_file(format!("{}/{}", p.dispaly(), bar.display()));

Could be written as:

    let _ = fs::create_file(p.join("bar"));
    let _ = fs::create_file(p..join(bar));
Comparison with existing lints

No response

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named in the issue. Start from the Rust examples and define the detection boundary and expected suggestion for Path::display cases; done means the intended cases and limitations are documented well enough to assess an implementation.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.