rust-lang / rust-lang/rust-clippy
`unused_unit` suggestion includes blank lines
Open
Beginner friendly
Nobody has claimed this yet.
C-bug
L-suggestion
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Summary
Clippy incorrectly formats a function body when removing a redundant unit expression (()), leaving behind an empty line.
Reproducer
Code:
pub fn foo(x: usize) -> () {
let _ = x;
()
}
Current output:
pub fn foo(x: usize) {
let _ = x;
}
Desired output:
pub fn foo(x: usize) {
let _ = x;
}
Version
clippy 0.1.97 (36ba2c7712 2026-04-23)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the unused_unit lint and reproduce the formatting shown in the issue using the provided Rust function. Trace the suggestion that removes the redundant () and add or update a regression test for the resulting formatting. Done means the suggestion removes the blank line and produces the desired output.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 75/100