rust-lang / rust-lang/rust-clippy

New Lint: Don't modify loop condition variables more than once per iteration

Open
#1,679 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint E-medium T-middle
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Based on this HIC++ guideline. To give you a short example of what would be linted:

while do_it != DoNothing {
    do_it = do_wörk();
    if special_case { do_it = magic(); } // WARNING: dude, you already modified `do_it`!
}

The idea is that for all mutable variables that are checked in a while loop's condition, this variable should only be modified once per iteration to simplify reasoning about the loop's control flow.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the issue's HIC++ guideline and the Rust example to define what counts as a loop-condition variable being modified more than once. Locate the Clippy entry point for implementing new lints and add coverage for the shown while-loop behavior; done means the repeated modification is reported without incorrectly flagging valid loops.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.