rust-lang / rust-lang/rust-clippy
Two suggestions for more DRY code
Open
Nobody has claimed this yet.
A-lint
good first issue
L-style
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Given this code:
struct Foo { cap: usize }
impl Foo {
fn new() -> Foo { Foo { cap: 1 } }
fn with_capacity(cap: usize) -> Foo {
Foo { cap: cap }
}
}
fn main() {}
In my opinion Clippy should suggest to replace four of those usages of "Foo" with "Self" and to remove one ": cap", making the code more DRY, the intended resulting code should be:
struct Foo { cap: usize }
impl Foo {
fn new() -> Self { Self { cap: 1 } }
fn with_capacity(cap: usize) -> Self {
Self { cap }
}
}
fn main() {}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points. Start from the Rust example and determine where Clippy handles these constructor and struct-field patterns; done means both suggestions produce the shown DRY code and are covered by appropriate lint tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100