rust-lang / rust-lang/rust-clippy
Lint `set_*` and `get_*` methods that do nothing but access the field
Open
Nobody has claimed this yet.
A-lint
good first issue
L-style
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
It is not idiomatic in Rust to have setters and getters. Make the field public instead.
If the type only has a get_foo method but not a set_foo method, suggest naming it foo instead.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source files or tests are named in the issue. Start by locating the existing Clippy lint implementations and their tests for accessor methods, then determine how the proposed lint should recognize trivial get_* and set_* methods. Done means the lint diagnoses those methods and suggests a public field or the field name where only get_* exists, with tests covering both cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100