rust-lang / rust-lang/rust-clippy
needless error conversion
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
I think it may make sense to suggest map_err simplification here. This is especially useful because thiserror provides automatic #[from] implementation
Advantage
- shorter, simpler code
Drawbacks
No response
Example
pub enum MyErr {
IoErr,
}
impl From<std::io::Error> for MyErr {
fn from(_: std::io::Error) -> Self {
MyErr::IoErr
}
}
fn foo(e: Result<(), std::io::Error>) -> Result<(), MyErr> {
// useless conversion here
e.map_err(MyErr::from)?;
// or e.map_err(|e| MyErr::from(e))?;
// should be replaced with `e?`
Ok(())
}
Comparison with existing lints
No response
Additional Context
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue does not identify implementation files or tests. Start by reviewing existing Clippy lints related to map_err and the thiserror #[from] pattern, then define which needless conversions should be diagnosed and how the example should be covered by tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100