rust-lang / rust-lang/rust-clippy
Extend `collapsible_if` to cover nested `if`s with identical `else`
Open
Nobody has claimed this yet.
C-enhancement
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Extend collapsible_if to cover nested ifs with identical else
For example:
let opt = Some(1);
let _ = if let Some(s) = opt {
if s == 1 { s } else { 1 }
} else {
1
};
Use instead:
let opt = Some(1);
let _ = if let Some(s) = opt
&& s == 1
{
s
} else {
1
};
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the collapsible_if lint implementation and its existing tests. Compare the nested-if example with the requested combined condition, then add coverage for identical else branches and verify that the lint produces the shown transformation without changing other cases.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100