rust-lang / rust-lang/rust-clippy
Rewrite `arithmetic_side_effects` to not use matching on string representation of types
Open
@keirsalterego is already working on this.
Since Feb 2, 2026.
C-enhancement
good first issue
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Description
arithmetic_side_effects uses the string representation of types to compare them. This will miss aliases (including core/alloc → std), takes longer to compare, etc.
It should use a method similar to what is done in the disallowed_types lint, where maps of DefId or PrimTy are built at lint initialization time and then used throughout the tree walk. Some type lookup code could probably even be shared (including the part where unloaded crates don't cause errors).
Version
Additional Labels
No response
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.