rust-lang / rust-lang/rust-clippy

Lint for no-argument methods that return String

Open
#1,626 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

I occasionally see people write methods like fn name() -> String which seems incorrect to me. These should all return &'static str if they don't change.

This would only apply to writing method signatures like this; implementing is fine.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No files, tests, or entry points are named in the issue. Start by locating rust-clippy's lint definitions and tests for method signatures, then determine how to distinguish no-argument methods returning String from implementations; done means the lint reports only the specified signatures and has coverage for the intended cases.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
devtools
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.