rust-lang / rust-lang/rust-clippy
`from_str_radix` hex "+" pitfall
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Description
This seems like a common mistake. It consists on using code like this:
uN::from_str_radix(hex_slice, 16)
to decode a hexadecimal string into an integer, unintentionally (in most cases) allowing + as a valid prefix for hex sequences. I say "unintentional" because hex-strs typically represent arbitrary data, not numbers/numerals.
[!note]
Prev paragraph was edited for clarity
IDK if there's an existing lint-rule where this should be included, or if it warrants a new lint, that's why I've opened a blank issue
Version
Additional Labels
@rustbot label +C-enhancement
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by investigating how Rust Clippy organizes existing lint rules related to from_str_radix and whether a rule already covers accepting a '+' prefix. The issue does not name files or tests, so identify the appropriate lint entry point and test location before defining the scope. Done should include a decided lint design and corresponding coverage for unintended '+' prefixes in hexadecimal parsing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100