rust-lang / rust-lang/rust-clippy

`needless_range_loop` suggestion removes panics

Open
#16,003 6 comments 0 reactions 1 assignee View on GitHub

Nobody has claimed this yet.

C-bug good first issue I-suggestion-causes-bug
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

Description

needless_range_loop currently suggests using take(n) when the iteration is not bounded by the vec's length. This is dangerous since it will silently truncate the iterated range which can very easily lead to data corruption. It may be fine to do so, but we don't have the necessary information to make that decision from clippy.


The following:

fn f() {
    let n = 15;
    let v = vec![1, 2];
    
    for i in 0..n {
        let _ = n;
        let _ = v[i];
    }
}

The current suggestion is effectively:

fn f() {
    let n = 15;
    let v = vec![1, 2];
    
    for (i, x) in v.iter().enumerate().take(n) {
        let _ = n;
        let _ = *x;
    }
}

It should be something that preserves the panic. e.g.:

fn f() {
    let n = 15;
    let v = vec![1, 2];
    
    for (i, x) in v[..n].iter().enumerate() {
        let _ = n;
        let _ = *x;
    }
}

Note that this will move the panic to occur before iteration rather than on the iteration that goes out of bounds. This behaviour is likely to be fine, but it should be called out by the lint when making this suggestion.

Version
clippy 0.1.91 (f8297e351a 2025-10-28)
Additional Labels

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.