rust-lang / rust-lang/rust-clippy
should_implement_trait should include ToOwned, FromStr
Open
Nobody has claimed this yet.
C-enhancement
good first issue
L-style
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Also see: servo/rust-url#286.
For FromStr, clippy should recommend that parse methods be renamed to from_str.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the should_implement_trait lint and its tests; the issue names no files or test paths. Compare the requested ToOwned and FromStr behavior with the linked servo/rust-url#286 discussion. Done means the lint covers both traits and recommends renaming parse methods to from_str where appropriate.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100