rust-lang / rust-lang/rust-clippy
Supports let-chains in `manual_strip`
Open
Nobody has claimed this yet.
C-enhancement
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Currently, the lint doesn't flag code like this:
#![warn(clippy::manual_strip)]
fn some_check() -> bool { todo!() }
fn foo(s: &str) {
if s.starts_with("ab")
&& let stripped = &s["ab".len()..]
&& some_check() // to avoid `irrefutable_let_patterns`
{
//
}
}
It would be cool if it would.
I think checking only consecutive ifs is fine.
@rustbot label C-enhancement
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the manual_strip lint and its existing tests, then reproduce the reported Rust example to understand the current behavior. Extend coverage for consecutive if conditions using let-chains, and consider the work done when the example is flagged without changing the stated scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100