rust-lang / rust-lang/rust-clippy
Lint functions taking references as arguments but only use them to create an owned value
Open
Nobody has claimed this yet.
A-lint
E-hard
good first issue
L-unnecessary
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
A function that takes a &str and always converts it to a String, should be taking a String argument instead. This is hard to generalize, but we could start with anything implementing to_owned and only calling to_owned.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by locating existing rust-clippy lints that inspect function arguments and ownership conversions, then determine how to recognize functions that take a reference and only call to_owned. Done means the lint handles the proposed cases without overgeneralizing and has coverage for its diagnostics.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 28/100