rust-lang / rust-lang/rust-clippy

Lint against unnecessary borrow_mut when borrow is enough

Open
#15,470 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Suggest replacing (try_)borrow_mut with (try_)borrow when the returned RefMut is not mutable and is not moved.

Advantage

Using borrow_mut but not using the mut ref is probably a bug

Drawbacks

No response

Example
use std::cell::RefCell;

fn f(cell: &RefCell<String>) {
    let Ok(s) = cell.try_borrow_mut() else {
        return;
    };
    println!("{}", s.len());
}

Could be written as:

use std::cell::RefCell;

fn f(cell: &RefCell<String>) {
    let Ok(s) = cell.try_borrow() else {
        return;
    };
    println!("{}", s.len());
}
Comparison with existing lints

No response

Additional Context

No response

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the issue's Rust example and compare the borrow_mut and borrow cases, then locate the existing Clippy lint entry point for borrow-related analysis. Done means the lint identifies unused mutability in the shown pattern without flagging cases where the mutable reference is needed or moved, with coverage for the demonstrated behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.