rust-lang / rust-lang/rust-clippy
Lint for extend with cloned copy types
Open
Nobody has claimed this yet.
A-lint
E-medium
L-unnecessary
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
Apparently, every struct S that implements Extend<T> for S<T> also implements Extend<&'a T> for S<T> where T: Copy, that means that s.extend(x.iter().cloned()) can be write s.extend(x.iter()) or even s.extend(x) if x is a reference to X and &X implements IntoIterator.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No implementation file or test is named. Start with the Rust Extend implementors documentation and the examples in the issue, then locate Clippy's lint registration and test conventions. Done means a lint identifies the redundant cloned extension for Copy types and tests cover the shown forms.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100