rust-lang / rust-lang/rust-clippy
Suggest pattern-matching structs instead of doing wall of lets
Open
Nobody has claimed this yet.
A-lint
E-medium
L-style
T-middle
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
For example, if I have:
struct Thing {
part1: u64,
part2: u64,
part3: u64,
}
Whenever someone does something like:
let part1 = thing.part1;
let mut part3 = thing.part3;
Offer to replace it with:
let Thing { part1, mut part3, .. } = thing;
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue provides Rust examples but names no files, tests, or entry points. Start by locating Clippy lint implementations and tests for existing suggestions involving destructuring. Done means the relevant pattern produces a suggestion using struct pattern matching while preserving mutable bindings and ignored fields.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100