rust-lang / rust-lang/rust-clippy

Suggestion of `explicit_infinite_iterator` for `OneSidedRange`

Open
#14,913 2 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

For a given iterator using a one sided range (i..) where i: T it suggests changing it with (i..T::Max).cycle() in the interest of explicitness.

Advantage
  • Remove divergence between debug and release builds(right now, the following code fails with overflow in debug, but goes into infinite loop in release mode.
fn main() {
    for i in 0_u8.. {
        println!("{}", i);
    }
}
  • It prevents unintentional infinite loops, aiding infinite_iter and maybe_infinite_iter
Drawbacks

It suggests a change in behavior for the debug build.

Example
fn main() {
    for i in 0_u8.. {
        println!("{}", i);
    }
}

Could be written as:

fn main() {
    for i in (0_u8..u8::MAX).cycle() {
        println!("{}", i);
    }
}

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by tracing how Clippy represents and tests iterator-related lints, then resolve the proposed behavior and debug-versus-release tradeoff before defining the lint's scope and acceptance tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.