rust-lang / rust-lang/rust-clippy
Replace push_str with the corresponding operator
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
This (probably pedantic) link suggests to replace calls to .push_str() with the corresponding operator.
Advantage
Shorter and more to the point code. And scripting language programmerer (as Python) are used to using operators for this.
Drawbacks
I don't know if there are drawbacks.
Example
fn main() {
let mut msg = String::from("Hello");
msg.push_str(", world");
println!("{msg}"); // Hello, world
}
Could be written as:
fn main() {
let mut msg = String::from("Hello");
msg += ", world";
println!("{msg}"); // Hello, world
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are named. Start by searching the repository for existing handling of String::push_str and related lint tests, then determine the appropriate entry point for this proposal. Done means the lint recognizes the applicable calls, offers the corresponding operator, and has coverage for the accepted cases and any identified drawbacks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 38/100