rust-lang / rust-lang/rust-clippy
Warn on large amounts of string matches
Open
Nobody has claimed this yet.
S-triage
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
I came up with this recently. More relevant, contrived example of such a match statement:
match s {
"string" | "str" | "STR" | "STRING" => ...,
"int" | "INT" | "integer" | "INTEGER" => ...,
"float" | "FLOAT" => ...,
}
After a certain number of strings and/or branches, it should be suggested to use Regex or RegexSet, which are more powerful and easier to maintain.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no files, tests, or entry points, so begin by locating the relevant Clippy lint implementation and its test cases. Establish the threshold and scope for string-heavy match branches, then verify that qualifying matches suggest Regex or RegexSet without affecting other matches.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100