rust-lang / rust-lang/rust-clippy
Useless by ref lint
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Helps remove some useless & from the code.
Advantage
Simpler code
Drawbacks
I don't know
Example
#![warn(clippy::all)]
#![warn(clippy::nursery)]
#![warn(clippy::pedantic)]
fn main() {
let items = [(1, 2), (3, 4)];
for &(x, y) in &items.map(|(x, y)| (-x, -y)) {
println!("{x} {y}");
}
}
Could be written as:
#![warn(clippy::all)]
#![warn(clippy::nursery)]
#![warn(clippy::pedantic)]
fn main() {
let items = [(1, 2), (3, 4)];
for (x, y) in items.map(|(x, y)| (-x, -y)) {
println!("{x} {y}");
}
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file, test, or entry point is named. Start by comparing the two Rust examples and define which uses of a leading ampersand are redundant. Done should be a Clippy lint that reports the demonstrated case and has clear behavior for its supported scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100