Don't lint rustfmt deprecated_cfg_attr on expr

Open
#14,606 1 comment 0 reactions 1 assignee View on GitHub

@profetia is already working on this.

Since Apr 14, 2025.

Assessment

This issue has not been assessed yet.

Description

C-bug I-false-positive
Summary

If repairing with lint help, an error will be triggered

error[E0658]: attributes on expressions are experimental
 --> src/main.rs:3:9
  |
3 |         #[rustfmt::skip]
  |         ^^^^^^^^^^^^^^^^
  |
  = note: see issue #15701 <https://github.com/rust-lang/rust/issues/15701> for more information
  = help: add `#![feature(stmt_expr_attributes)]` to the crate attributes to enable
  = note: this compiler was built on 2025-04-01; consider upgrading it if it is out of date

For more information about this error, try `rustc --explain E0658`.
Lint Name

deprecated_cfg_attr

Reproducer

I tried this code:

fn main() {
    let _n = {
        #[cfg_attr(rustfmt, rustfmt::skip)]
        (
            1
        )
    };
}

I saw this happen:

warning: `cfg_attr` is deprecated for rustfmt and got replaced by tool attributes
 --> src/main.rs:3:9
  |
3 |         #[cfg_attr(rustfmt, rustfmt::skip)]
  |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `#[rustfmt::skip]`
  |
  = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_cfg_attr
  = note: `#[warn(clippy::deprecated_cfg_attr)]` on by default

I expected to see this happen:
no warnings

Version
rustc 1.88.0-nightly (e2014e876 2025-04-01)
binary: rustc
commit-hash: e2014e876e3efaa69bf51c19579adb16c3df5f81
commit-date: 2025-04-01
host: aarch64-unknown-linux-gnu
release: 1.88.0-nightly
LLVM version: 20.1.1
Additional Labels

No response

Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from rust-lang/rust-clippy

All issues in rust-lang/rust-clippy

Similar issues

More Rust issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.