rust-lang / rust-lang/rust-clippy
Suggest using `next_multiple_of()` instead of `((x + N-1) / N) * N` or `(x + N-1) & !(N-1)` (for powers of two)
Open
Nobody has claimed this yet.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
See title.
Similar for x.is_multiple_of(y) and x % y == 0.
Advantage
More readable and overflow checks
Drawbacks
No response
Example
let x = ((x + 3) / 4) * 4;
let y = (y + 3) & !3;
let z = z % 4 == 0;
Could be written as:
let x = x.next_multiple_of(4);
let y = y.next_multiple_of(4);
let z = z.is_multiple_of(4);
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue provides no file or test entry point; start by reviewing its arithmetic examples and the requested next_multiple_of() and is_multiple_of() replacements. Done means establishing the lint scope and behavior for these patterns, including the power-of-two case and overflow-checking rationale, with corresponding validation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- tooling
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100