rust-lang / rust-lang/rust-clippy
Unnecessary Parentheses Improvement
Open
@DeepakSilaych is already working on this.
Since Mar 19, 2025.
A-lint
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
What it does
Currently, normal if clauses work as intended:
unnecessary parentheses around
ifcondition: remove these parentheses
if (authorization.chars().count() < 100) {
/*authorization must be at least 100 characters long*/
return None;
}
However, when the if clause is negated, it doesn't get recognized.
I'd suggest adding a linter for negated if clauses as well.
Advantage
- Increase consistency between linter hints
- Readability
Drawbacks
No response
Example
if !(authorization.starts_with("ey")) {
/*authorization must start with ey*/
return None;
}
Could be written as:
if !authorization.starts_with("ey") {
/*authorization must start with ey*/
return None;
}
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.