rust-lang / rust-lang/rust-clippy

Warn on unused for<'a> lifetime

Open
#14,334 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Given:

struct Foo(Box<dyn for<'a> Fn(&u32)>);

The for<'a> is redundant, since the lifetime is not mentioned.

Advantage
  • Remove dead code
  • Consistency with clippy::extra_unused_lifetimes which can already detect dead lifetimes such as:
fn foo<'a>(x: u32) {}

In fact, this suggestion may be reasonable as an extension to the existing unused_lifetimes code.

Drawbacks

None I can think of

Example
struct Foo(Box<dyn for<'a> Fn(&u32)>);

Could be written as:

struct Foo(Box<dyn Fn(&u32)>);

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue does not name implementation files or tests. Start by locating Clippy's existing unused_lifetimes lint and compare how it detects redundant lifetimes; the work is complete when the shown for<'a> lifetime produces an appropriate warning and removing it is covered by a test.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.