rust-lang / rust-lang/rust-clippy
improve suggestions around `&*` and don't add parenthesis
Open
Nobody has claimed this yet.
C-enhancement
good first issue
L-suggestion
- Dominant language
- Rust
- Stars
- 13.5k
- Forks
- 2.2k
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 32
Description
~~Is there ever a reason to have an unsized type and ref it instead of having a reference to an unsized type?
I think we should simply suggest to use let p: &str = &*"hello"; instead (and make sure our quoting code erases &* or sth)
E-medium because I'm wary of weird consequences for cases I didn't think about.~~
make sure our quoting code erases &*
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names no file or test; start by locating the lint's suggestion and quoting code. Check how the suggestion is built, then verify that quoting removes &* and does not add parentheses, using the relevant lint tests to confirm the resulting suggestion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 32/100