rust-lang / rust-lang/rust-clippy

Complex use of `Vec`/`VecDeque` `remove`

Open
#14,072 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

A-lint
Dominant language
Rust
Stars
13.5k
Forks
2.2k
Avg merge
2d 10h
Merged PRs (30d)
32

Description

What it does

Detect uses of Vec::remove or VecDeque::remove when Vec::pop, VecDeque::pop_front or VecDeque::pop_back could have been used

Advantage
  • Makes the code easier to read
  • Possibly makes the code run faster
Drawbacks
  • In the case of Vec::remove it would break code because it changes the return type from T to Option<T>
Example
vec.remove(vec.len() - 1);

vec_deque.remove(0);
vec_deque.remove(vec_deque.len() - 1);

Could be written as:

vec.pop();

vec_deque.pop_front();
vec_deque.pop_back();

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the existing Clippy lint entry points and tests for collection-method patterns, then compare how calls to Vec::remove and VecDeque::remove are analyzed. Use the examples in the issue to define the pop, pop_front, and pop_back cases, while checking the Vec::remove return-type drawback. Done means the intended cases are detected with tests covering the suggested replacements.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.